Re: uuid patch 3.0 (8.3devel)

From: Neil Conway <neilc(at)samurai(dot)com>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: Gevik Babakhani <pgdev(at)xs4all(dot)nl>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: uuid patch 3.0 (8.3devel)
Date: 2007-01-28 22:06:10
Message-ID: 1170021970.29138.44.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Sun, 2007-01-28 at 13:08 -0500, Kris Jurka wrote:
> This fails on Solaris 9 buildfarm members kudu and dragonfly because they
> do not support the "hh" scanf modifier using in UUID_FMTx.

Hmmm. I suppose the easiest thing to do would be to rewrite the uuid
parsing function to not depend on sscanf(). On thinking about it more,
perhaps we should be using the in-memory layout described by RFC 4122:

struct pg_uuid_t
{
uint32 time_low;
uint16 time_mid;
uint16 time_hi_and_version;
uint8 clock_seq_hi_and_reserved;
uint8 clock_seq_low;
char[6] node;
};

But that can wait for later. Working on fixing the parsing code, I'll
post a patch shortly.

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message David Fetter 2007-01-28 23:36:11 Re: [ADMIN] server process (PID xxx) was
Previous Message Bruce Momjian 2007-01-28 22:02:24 Re: [ADMIN] server process (PID xxx) was