Re: 8.2.0 Tarball vs. REL8_2_0 vs. REL8_2_STABLE

From: "Matt Miller" <pgsql(at)mattmillersf(dot)fastmail(dot)fm>
To: pgsql-hackers(at)postgresql(dot)org
Cc: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Subject: Re: 8.2.0 Tarball vs. REL8_2_0 vs. REL8_2_STABLE
Date: 2006-12-18 20:53:25
Message-ID: 1166475205.24308.281048787@webmail.messagingengine.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

> > The [pgcluster-1.7.0rc1-patch] patch applies to the 8.2.0 tarball ...
> > However, the patch will not apply to cvs branch REL8_2_0.
>
> I've been told that the pgcluster patch patches some generated files
> (parse.h and other apparently).

Yes, I could not at first apply to REL8_2_0 because the patch file
wanted to patch src/backend/parser/gram.c. At that point I started over
with a fresh REL8_2_0, ran "./configure; make", and tried the patch
again. That's when I got a bunch of failures and fuzz. The problem
files are:

src/backend/parser/gram.c
src/backend/parser/parse.h
src/interfaces/libpq/libpq.rc

So, I suppose libpq.rc is a derived file, also?

Now I have two questions. First, why does pgcluster patch derived
files? Is this just sloppy/lazy technique, or could there be some
deeper reason? I realize this is properly to be posed to the pgcluster
folks, but they don't seem to be too responsive, at least not to their
pgfoundry forums.

Second, does it make sense that the derived files that rejected the
patch would be so different between the 8.2.0 tarball and my
REL8_2_0 build?

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2006-12-18 21:09:21 Re: 8.2.0 Tarball vs. REL8_2_0 vs. REL8_2_STABLE
Previous Message Andrew Dunstan 2006-12-18 20:13:27 Re: 8.2.0 Tarball vs. REL8_2_0 vs. REL8_2_STABLE

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-12-18 21:06:24 Re: Typo in pg_dump documentation and new suggestion for Release Notes
Previous Message Magnus Hagander 2006-12-18 20:45:43 effective_cache_size vs units