From: | Neil Conway <neilc(at)samurai(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Gevik Babakhani <pgdev(at)xs4all(dot)nl>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: An Idea for OID conflicts |
Date: | 2006-09-18 20:28:06 |
Message-ID: | 1158611286.5274.16.camel@localhost.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 2006-09-18 at 14:10 -0400, Andrew Dunstan wrote:
> My idea was to have a file called reserved_oids.h which would contain
> lines like:
>
> #error "do not include this file anywhere"
> CATALOG(reserved_for_foo_module,9876) /* 2006-09-18 */
>
> and which would be examined by the unused_oids script.
Or you needn't even use a header file -- presumably it wouldn't actually
be included by any C source files, so you could just keep the reserved
OIDs as a newline-separated text file. We'd probably want to design the
file format to avoid unnecessary patch conflicts when reserved OID
ranges are removed.
I wonder if the additional committer burden of maintaining this file is
worth it -- personally this problem rarely occurs in practice for me,
and when it does, it is easily resolved via the existing scripts for
finding duplicate and unused OIDs.
-Neil
From | Date | Subject | |
---|---|---|---|
Next Message | Merlin Moncure | 2006-09-18 20:30:10 | Re: 8.2 beta blockers |
Previous Message | Tom Lane | 2006-09-18 20:23:41 | Re: An Idea for OID conflicts |