Re: Fix C4819 warning in MSVC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix C4819 warning in MSVC
Date: 2021-11-01 13:56:01
Message-ID: 1131200.1635774961@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> Reading 1051867(dot)1635720347(at)sss(dot)pgh(dot)pa(dot)us I noticed that hamerkop raise a C4819
> warning on brin_bloom.c, which is defined as:
> "The file contains a character that cannot be represented in the current
> code page (number). Save the file in Unicode format to prevent data loss."
> The warning message is mostly gibberish but AFAICT the issue is that the
> headercomment includes a citation to the paper used for the hashing scheme, in
> which a footnote character has been copied from the paper (without the footnote
> copied). Since the footnote is irrelevant for our documentation, I propose to
> remove this offending character to remove warnings from the build.

+1, but there are also C4819 warnings in fe_utils/print.c. Can we get
rid of that too? That one's a bit more integral to the code, since
(I think) it's complaining about the comments in the unicode_style table.
But maybe we could replace those with Unicode codes + symbol names?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-11-01 14:01:54 Re: pgbench bug candidate: negative "initial connection time"
Previous Message Andrew Dunstan 2021-11-01 13:48:32 Re: remove internal support in pgcrypto?