Re: pg_archivecleanup bug

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_archivecleanup bug
Date: 2013-12-06 16:10:27
Message-ID: 11304.1386346227@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Dec 5, 2013 at 6:15 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> In general, I think there is no excuse for code in the backend to use
>> readdir() directly; it should be using ReadDir(), which takes care of this
>> as well as error reporting.

> My understanding is that the fd.c infrastructure can't be used in the
> postmaster.

Say what? See ParseConfigDirectory for code that certainly runs in the
postmaster, and uses ReadDir().

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-12-06 16:14:14 commit fest 2013-11 week 3 report
Previous Message Greg Stark 2013-12-06 16:05:45 Re: ANALYZE sampling is too good