| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Joe Conway <mail(at)joeconway(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Should we document IS [NOT] OF? |
| Date: | 2020-11-19 17:08:20 |
| Message-ID: | 1129826.1605805700@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Thu, Nov 19, 2020 at 11:15:33AM -0500, Joe Conway wrote:
>> On 11/19/20 11:06 AM, Tom Lane wrote:
>>> Let's just rip it out and be done. If anyone is ever
>>> motivated to make it work per spec, they can resurrect
>>> whatever seems useful from the git history.
>> +1
> +1
Here's a proposed patch for that. I was amused to discover that we have
a couple of regression test cases making use of IS OF. However, I think
using pg_typeof() is actually better for those tests anyway, since
printing the regtype result is clearer, and easier to debug if the test
ever goes wrong.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| remove-IS-OF.patch | text/x-diff | 12.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tels | 2020-11-19 17:19:44 | Re: Tab complete for CREATE OR REPLACE TRIGGER statement |
| Previous Message | Robert Haas | 2020-11-19 17:06:36 | Re: new heapcheck contrib module |