Re: PITR on Win32 - Archive and Restore

From: markir(at)coretech(dot)co(dot)nz
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgman(at)candle(dot)pha(dot)pa(dot)us, pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: PITR on Win32 - Archive and Restore
Date: 2004-08-11 01:51:15
Message-ID: 1092189075.ee3eb03068eb7@mail.coretech.co.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

I agree, the approach seems quite nice.

I gave the lastest cvs a go - which is probably cvs as of about 2 hours ago, as
a mingw build takes 55 minutes on this machine (compare to 6 minutes when
booted into Freebsd... ah well..)

Initially tried :

archive_command = 'copy "%p" "c:\databases\pgarchive\%f"'

But saw errors in the log about "c:databasespgarchive00000..."

Looks like '\' needs to be escaped, confirmed this with :

archive_command = 'copy "%p" "c:\\databases\\pgarchive\\%f"'

Which worked fine. However, it would be nice if the '\' inside the '"' were
'auto-escaped' somehow, as I suspect Mr 'used-windows-all-my-life' will find
the current behaviour counter-intuitive.

Otherwise looks good

Mark

Quoting Andrew Dunstan <andrew(at)dunslane(dot)net>:

> Tom Lane said:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> I have gotten confused by this. Does COPY work with quoted paths only
> >> if we use forward slashes, or was this fix just for the slash issue
> >> and not spaces?
> >
> > This only fixes the slash issue. If your database path includes spaces
> > you'll still need to put quotes in the archive_command, but it
> > shouldn't be any worse than
> > archive_command = 'copy "%p" "c:\someplace\%f"'
> >
> > I'd appreciate confirmation though from some win32 users that the above
> > indeed works.
> >
>
> That's what my experimentation showed, although I worked with a tiny test.c
> file rather than the archive command. I think this is the right solution -
> the user should put the quotes in, not postgres.
>
> cheers
>
> andrew
>
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message markir 2004-08-11 01:57:29 Re: PITR on Win32 - Archive and Restore
Previous Message Dru 2004-08-10 23:56:05 problem with postgresql starting.

Browse pgsql-patches by date

  From Date Subject
Next Message markir 2004-08-11 01:57:29 Re: PITR on Win32 - Archive and Restore
Previous Message Bruce Momjian 2004-08-11 01:42:11 Re: 8.0.0beta1: -lpthread missing