Re: Acceptable/Best formatting of callbacks (for pluggable storage)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Acceptable/Best formatting of callbacks (for pluggable storage)
Date: 2019-01-11 14:42:19
Message-ID: 1092.1547217739@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> The pluggable storage patchset has a large struct full of callbacks, and
> a bunch of wrapper functions for calling those callbacks. While
> starting to polish the patchset, I tried to make the formatting nice.
> ...
> So, putting the parameter list, both in use and declaration, entirely
> into a new line yields decent formatting with pgindent. But it's kinda
> weird. I can't really come up with a better alternative, and after a
> few minutes it looks pretty reasonable.

> Comments? Better alternatives?

Use shorter method names? This sounds like an ugly workaround for
a carpal-tunnel-syndrome-inducing design.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-01-11 14:48:02 Re: Three animals fail test-decoding-check on REL_10_STABLE
Previous Message Tom Lane 2019-01-11 14:31:24 Re: unnecessary creation of FSM files during bootstrap mode