Skip site navigation (1) Skip section navigation (2)

Re: PITR COPY Failure (was Point in Time Recovery)

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Mark Kirkwood <markir(at)coretech(dot)co(dot)nz>,pgsql-hackers(at)postgresql(dot)org
Subject: Re: PITR COPY Failure (was Point in Time Recovery)
Date: 2004-07-20 14:24:16
Message-ID: 1090333455.28049.2917.camel@stromboli (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-adminpgsql-hackerspgsql-patches
On Tue, 2004-07-20 at 15:00, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > On Tue, 2004-07-20 at 13:51, Tom Lane wrote:
> >> Ugh.  I'm beginning to think we ought to revert the patch that added the
> >> don't-split-across-files logic to XLogInsert; that seems to have broken
> >> more assumptions than I realized.
> 
> > The problem was that a zero length XLOG_WASTED_SPACE record just fell
> > out of ReadRecord when it shouldn't have. By giving it a helping hand it
> > makes it through with pointers correctly set, and everything else was
> > already thought of in the earlier patch, so xlog_redo etc happens.
> 
> Yeah, but the WASTED_SPACE/FILE_HEADER stuff is already pretty ugly, and
> adding two more warts to the code to support it is sticking in my craw.
> I'm thinking it would be cleaner to treat the extra labeling information
> as an extension of the WAL page header.

Sounds like a better solution than scrabbling around at the end of file
with too many edge cases to test properly 

...over to you then...

Best Regards, Simon Riggs


In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2004-07-20 14:35:20
Subject: Re: pg_config
Previous:From: Simon RiggsDate: 2004-07-20 14:19:40
Subject: Re: PITR COPY Failure (was Point in Time Recovery)

pgsql-admin by date

Next:From: Kris KigerDate: 2004-07-20 15:09:19
Subject: Re: Large file support needed? Trying to identify root of
Previous:From: Simon RiggsDate: 2004-07-20 14:19:40
Subject: Re: PITR COPY Failure (was Point in Time Recovery)

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-07-20 14:34:20
Subject: Re: logfile subprocess and Fancy File Functions
Previous:From: Simon RiggsDate: 2004-07-20 14:19:40
Subject: Re: PITR COPY Failure (was Point in Time Recovery)

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group