Re: PITR COPY Failure (was Point in Time Recovery)

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Mark Kirkwood <markir(at)coretech(dot)co(dot)nz>,pgsql-hackers(at)postgresql(dot)org
Subject: Re: PITR COPY Failure (was Point in Time Recovery)
Date: 2004-07-20 14:24:16
Message-ID: 1090333455.28049.2917.camel@stromboli
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-admin pgsql-hackers pgsql-patches

On Tue, 2004-07-20 at 15:00, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > On Tue, 2004-07-20 at 13:51, Tom Lane wrote:
> >> Ugh. I'm beginning to think we ought to revert the patch that added the
> >> don't-split-across-files logic to XLogInsert; that seems to have broken
> >> more assumptions than I realized.
>
> > The problem was that a zero length XLOG_WASTED_SPACE record just fell
> > out of ReadRecord when it shouldn't have. By giving it a helping hand it
> > makes it through with pointers correctly set, and everything else was
> > already thought of in the earlier patch, so xlog_redo etc happens.
>
> Yeah, but the WASTED_SPACE/FILE_HEADER stuff is already pretty ugly, and
> adding two more warts to the code to support it is sticking in my craw.
> I'm thinking it would be cleaner to treat the extra labeling information
> as an extension of the WAL page header.

Sounds like a better solution than scrabbling around at the end of file
with too many edge cases to test properly

...over to you then...

Best Regards, Simon Riggs

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-07-20 14:35:20 Re: pg_config
Previous Message Simon Riggs 2004-07-20 14:19:40 Re: PITR COPY Failure (was Point in Time Recovery)

Browse pgsql-admin by date

  From Date Subject
Next Message Kris Kiger 2004-07-20 15:09:19 Re: Large file support needed? Trying to identify root of
Previous Message Simon Riggs 2004-07-20 14:19:40 Re: PITR COPY Failure (was Point in Time Recovery)

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-07-20 14:34:20 Re: logfile subprocess and Fancy File Functions
Previous Message Simon Riggs 2004-07-20 14:19:40 Re: PITR COPY Failure (was Point in Time Recovery)