Re: Proposed GUC Variable

From: Larry Rosenman <ler(at)lerctr(dot)org>
To: "Ross J(dot) Reedstrom" <reedstrm(at)rice(dot)edu>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposed GUC Variable
Date: 2002-08-27 22:31:53
Message-ID: 1030487513.410.56.camel@lerlaptop.iadfw.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Tue, 2002-08-27 at 17:30, Ross J. Reedstrom wrote:
> On Tue, Aug 27, 2002 at 06:08:40PM -0400, Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > But we should have some default to print some of the query,
> >
> > Why? So far you've been told by two different people (make that three
> > now) that such a behavior is useless, and no one's weighed in in its
> > favor ...
>
> I agree that a 'trimmed' query is likely to be useless, but the idea of
> printing the query on ERROR is a big win for me: right now I'm logging
> _all_ queries on our development machine (and sometimes on our production
> machine. when there's trouble) so my logs would get considerably smaller.
I agree with printing the query on error... just not limiting it to 80
characters by default.
>
> A settable trim length would probably be a good idea, I suppose, for
> those slinging 'bytea' and toasted texts around.
Yes, but the default should be NO TRIM or in 1K-4K range. IMHO

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-08-27 22:32:48 Re: fix for palloc() of user-supplied length
Previous Message Ross J. Reedstrom 2002-08-27 22:30:04 Re: Proposed GUC Variable

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-08-27 22:32:48 Re: fix for palloc() of user-supplied length
Previous Message Ross J. Reedstrom 2002-08-27 22:30:04 Re: Proposed GUC Variable