| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Enable -Wstrict-prototypes and -Wold-style-definition by default |
| Date: | 2026-03-18 19:29:00 |
| Message-ID: | 1012008.1773862140@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> writes:
> On Wed, Mar 18, 2026 at 01:03:03PM -0400, Tom Lane wrote:
>> We could plausibly fix this either by
>>
>> (1) renaming ecpg_init_sqlca's parameter to something else;
>>
>> (2) ensuring that POSTGRES_ECPG_INTERNAL is defined. I'd be inclined
>> to make ecpglib_extern.h do that rather than expecting headerscheck
>> to know about it.
>>
>> Neither of these options are beautiful, but perhaps #1 is slightly
>> less ugly. Any preferences?
> I'd vote for #1 too, done in the attached.
Agreed and pushed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-03-18 19:30:10 | Re: Better shared data structure management and resizable shared data structures |
| Previous Message | Nathan Bossart | 2026-03-18 19:24:42 | Re: pg_restore --format= option(without any value) should report an error as pg_dump is reporting an error |