Update comments in nodeModifyTable.c

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Update comments in nodeModifyTable.c
Date: 2017-06-05 08:45:51
Message-ID: 10026bc7-1403-ef85-9e43-c6100c1cc0e3@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

While working on [1], I noticed that the comment in ExecModifyTable:

* Foreign table updates have a wholerow attribute when the
* relation has an AFTER ROW trigger.

is not 100% correct because a foreign table has a wholerow attrubute
when the relation has an AFTER ROW or BEFORE ROW trigger (see
rewriteTargetListUD). So I'd propose s/an AFTER ROW trigger/a row-level
trigger/. Attached is a patch for that.

Best regards,
Etsuro Fujita


Attachment Content-Type Size
nodeModifyTable-comment-update.patch text/plain 1.1 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Tianzhou Chen 2017-06-05 08:49:34 Challenges preventing us moving to 64 bit transaction id (XID)?
Previous Message Ashutosh Bapat 2017-06-05 08:39:53 Re: Bug in ExecModifyTable function and trigger issues for foreign tables