Re: pgbench - rework variable management

From: David Steele <david(at)pgmasters(dot)net>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - rework variable management
Date: 2020-03-27 22:42:49
Message-ID: 0f0e853a-71d7-60ad-f6f1-6dd92d1b0fc0@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/27/20 6:25 PM, Fabien COELHO wrote:
>
>>> Patch v5 is a rebase with some adjustements.
>>
>> This patch is failing on the Windows build:
>> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.85698
>>
>>
>> I'm not sure if this had been fixed in v3 and this is a new issue or
>> if it has been failing all along.  Either way, it should be updated.
>
> I don't do windows, so the mutex stuff for windows is just blind
> programming.
>
>> Marked Waiting on Author.
>>
>> BTW -- sorry if I seem to be picking on your patches but these happen
>> to be the patches with the longest time since any activity.
>
> Basically, my areas of interest do not match committers' areas of interest.
>
> v6 is a yet-again blind attempt at fixing the windows mutex. If someone
> with a windows could tell me if it is ok, and if not what to fix, it
> would be great.

Regarding Windows testing you may find this thread useful:

https://www.postgresql.org/message-id/CAMN686ExUKturcWp4POaaVz3gR3hauSGBjOCd0E-Jh1zEXqf_Q%40mail.gmail.com

--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Glukhov 2020-03-27 22:43:35 Re: fix for BUG #3720: wrong results at using ltree
Previous Message Bruce Momjian 2020-03-27 22:39:46 Re: backup manifests