Re: postgres_fdw: transaction mode inheritance corner cases

From: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: postgres_fdw: transaction mode inheritance corner cases
Date: 2026-10-06 12:21:09
Message-ID: 0e6aec59-21e2-440f-b4ff-f760a0dc5549@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/10/26 05:22, Etsuro Fujita wrote:
> On Sat, Oct 3, 2026 at 9:04 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>> On Sat, Oct 3, 2026 at 6:38 PM Matheus Alcantara
>> <matheusssilv97(at)gmail(dot)com> wrote:
>>> On Fri Oct 2, 2026 at 12:54 PM -03, Etsuro Fujita wrote:
>>>> Here is an updated version for that. This is
>>>> an existing issue, so I split it into two:
>>>>
>>>> * v2-0001-Fix-open-cursor-handling.patch
>>>> This addresses the existing issue by disallowing the fetching (and the
>>>> issue #1 reported by Fujii-san as a side effect).
>>>>
>>>> * v2-0002-Fix-xact-prop-issues.patch
>>>> This addresses the remaining issues #2, #3 and #5 reported by
>>>> Fujii-san (#4 is not a bug). I will add test cases next.
>>>
>>> Thanks for the v2 patches! I tested them and the hot standby issue is
>>> fixed by 0002, and the deferred trigger case works as expected. I found
>>> two problems with 0001, 0002 looks good to me.
>
>> I added the test cases to 0002. Attached is a new version of the
>> patch. (It actually doesn't depend on 0001, so I'm only attaching
>> 0002.) I will push/backpatch the new version first if no objections
>> from others.
>
> Done.
>
>> As for 0001, I also noticed problem #1 after sending the email...
>> 0001 is an existing issue, so I will return to it, including your
>> patch, after closing this open item.
>
> I closed it and added the existing issue to Live issues.
>

Thank you!

Are you still planning to review 0001 and 0003 on this thread or
should I start a new one to discuss these patches?

--
Matheus Alcantara
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Burd 2026-10-06 12:25:50 Re: Tepid: selective index updates for heap relations
Previous Message Zhijie Hou 2026-10-06 12:19:48 Re: Publication DDL can race with a concurrent UPDATE