| From: | Yuchen Li <liyuchen_xyz(at)163(dot)com> |
|---|---|
| To: | "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: docs: Fix format of CREATE FOREIGN TABLE example in postgres_fdw |
| Date: | 2026-04-16 09:17:24 |
| Message-ID: | 0e537c2a-0575-48c8-a9ac-78030f36a1ef@163.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/15/2026 5:27 PM, Daniel Westermann (DWE) wrote:
> Hi,
>
> while reading https://www.postgresql.org/docs/devel/postgres-fdw.html
> <https://www.postgresql.org/docs/devel/postgres-fdw.html> I've noticed
> that there is a single bracket on one line of the CREATE FOREIGN TABLE
> example.
>
> Browsing through other docs (e,g.
> https://www.postgresql.org/docs/devel/sql-createtable.html
> <https://www.postgresql.org/docs/devel/sql-createtable.html> ) there
> doesn't seem to be a rule for that but if there is a single bracket
> (e.g. CREATE TABLE distributors), the options that follow usually
> start at position one and are not indented (or they follow directly
> after the bracket).
>
> The examples in file_fdw
> (https://www.postgresql.org/docs/devel/file-fdw.html) follow a mix of
> options which directly follow the bracket and on a new line.
>
> Attached a small patch which makes it looking a bit better, at least
> in my opinion.
>
> Regards
> Daniel
While looking through the patch, I noticed a small formatting issue in
the following part:
+)
+SERVER foreign_server
+OPTIONS (schema_name 'some_schema', table_name 'some_table');
The added +) line appears to have a trailing space after the closing
parenthesis.
Regards,
Yuchen Li
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2026-04-16 09:28:47 | Re: Reject invalid databases in pg_get_database_ddl() |
| Previous Message | Peter Eisentraut | 2026-04-16 08:45:55 | Re: Reduce build times of pg_trgm GIN indexes |