| From: | "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | docs: Fix format of CREATE FOREIGN TABLE example in postgres_fdw |
| Date: | 2026-04-15 09:27:01 |
| Message-ID: | ZR2PPFF1830B8773AC9735393FFF93F8665D2222@ZR2PPFF1830B877.CHEP278.PROD.OUTLOOK.COM |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
while reading https://www.postgresql.org/docs/devel/postgres-fdw.html I've noticed that there is a single bracket on one line of the CREATE FOREIGN TABLE example.
Browsing through other docs (e,g. https://www.postgresql.org/docs/devel/sql-createtable.html ) there doesn't seem to be a rule for that but if there is a single bracket (e.g. CREATE TABLE distributors), the options that follow usually start at position one and are not indented (or they follow directly after the bracket).
The examples in file_fdw (https://www.postgresql.org/docs/devel/file-fdw.html) follow a mix of options which directly follow the bracket and on a new line.
Attached a small patch which makes it looking a bit better, at least in my opinion.
Regards
Daniel
| Attachment | Content-Type | Size |
|---|---|---|
| fix-create-foreign-table-example-format.patch | text/x-patch | 624 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2026-04-15 09:27:29 | Re: Add errdetail() with PID and UID about source of termination signal |
| Previous Message | Thomas Munro | 2026-04-15 09:26:43 | Re: Questionable description about character sets |