| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Align tests for stored and virtual generated columns |
| Date: | 2026-03-27 15:00:42 |
| Message-ID: | 0dddf337-dc15-4172-b9e5-58c24fdb64cd@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08.08.25 04:51, Yugo Nagata wrote:
> I noticed that the tests for virtual and stored generated columns
> contain the following comment;
>
> -- keep these tests aligned with generated_stored.sql (or generated_virtual.sql)
>
> However, it seems that some additional tests for virtual generated columns
> disrupted that alignment, as they were not added to generated_stored.sql.
>
> I've attached a patch to restore the alignment.
>
> In addition, I moved the test confirming that user-defined types are not allowed
> in virtual generated columns to the generated_virtual.sql-specific section,
> since this test is not necessary for stored generated columns.
Committed, thanks.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-03-27 15:01:03 | Re: [PATCH] Fix unexpected loss of DEFERRABLE property after toggling NOT ENFORCED / ENFORCED |
| Previous Message | Tom Lane | 2026-03-27 14:55:23 | Re: Add "format" target to make and ninja to run pgindent and pgperltidy |