Re: Fix data checksum processing for temp relations and dropped databases

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix data checksum processing for temp relations and dropped databases
Date: 2026-07-10 08:32:22
Message-ID: 0DD97859-0A1E-47ED-8082-297CF84391F9@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 10 Jul 2026, at 02:12, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Jul 9, 2026 at 4:56 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> I like this suggestion, though I think it should go after the call to
>> pgstat_progress_update_param since the db in question reached ProcessDatabase.
>> I would add it as an else-if case to the conditional testing we have for
>> _FAILED and _ABORTED.
>
> Thanks for the review! I've updated the patch based on
> your and Horiguchi-san's suggestions.

+1, v2 LGTM.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2026-07-10 08:36:33 Re: pgbench --continue-on-error: clarify TPS and failure reporting
Previous Message Daniel Gustafsson 2026-07-10 08:29:15 Re: Fix pg_stat_progress_data_checksums counter initialization