From: | Alban Hertroys <dalroi(at)solfertje(dot)student(dot)utwente(dot)nl> |
---|---|
To: | Thom Brown <thombrown(at)gmail(dot)com> |
Cc: | pgsql-php(at)postgresql(dot)org, PGSQL Mailing List <pgsql-general(at)postgresql(dot)org> |
Subject: | Re: PostgreSQL driver for Joomla review |
Date: | 2009-10-20 17:29:07 |
Message-ID: | 0C148B43-DF74-4DA6-866E-9903A540797D@solfertje.student.utwente.nl |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-php |
On 20 Oct 2009, at 14:02, Thom Brown wrote:
> If anyone has a moment, could they review the PostgreSQL driver I
> wrote for Joomla's next major release? The developers at Joomla have
> listened to the persistent noise created about only having MySQL as an
> option and are now accepting submissions for alternative database
> systems. (see http://groups.google.com/group/joomla-dev-cms/browse_thread/thread/1382dc6f4af56278#msg_9b95648941ef6fa7
> for this development)
>
> My submission can be found at:
> http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=18384
>
> Things to watch out for a version-dependent features and clumsy
> implementations.
You miss a keyword in your query in renameTable; it should be " RENAME
TO ", not " TO ".
Wouldn't it be convenient to have an EXPLAIN ANALYSE version of explain
()? Maybe with a boolean parameter?
In insertObject() you have a query "SELECT $keyName AS 'id' FROM
$table'" - That line contains two syntax errors: 'id' (You probably
meant "id") and $table' (spurious trailing quote).
Regards,
Alban Hertroys
--
Screwing up is the best way to attach something to the ceiling.
!DSPAM:737,4addf36611682031315238!
From | Date | Subject | |
---|---|---|---|
Next Message | John | 2009-10-20 18:45:41 | Re: multi-company design/structure ? |
Previous Message | Andreas Kretschmer | 2009-10-20 17:24:52 | Re: Count occurrences of pattern in string |
From | Date | Subject | |
---|---|---|---|
Next Message | Thom Brown | 2009-10-20 19:00:19 | Re: PostgreSQL driver for Joomla review |
Previous Message | Thom Brown | 2009-10-20 14:02:18 | Re: PostgreSQL driver for Joomla review |