|From:||"Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>|
|To:||'Robert Haas' <robertmhaas(at)gmail(dot)com>, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>|
|Cc:||Peter van Hardenberg <pvh(at)pvh(dot)ca>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Patch: Implement failover on libpq connect level.|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
> [mailto:pgsql-hackers-owner(at)postgresql(dot)org] On Behalf Of Robert Haas
> Great, committed. There's still potentially more work to be done here,
> because my patch omits some features that were present in Victor's original
> submission, like setting the failover timeout, optionally randomizing the
> order of the hosts, and distinguishing between master and standby servers;
> Victor, or anyone, please feel free to submit separate patches for those
The attached patch fixes some bugs and make a clarification for doc. Could you check and test the authentication stuff as I don't have an environment at hand?
There was a memory leak.
(2) fe-secure_openssl.c, fe-auth.c
GSSAPI/SSPI/SSL authentication requires the target host name, but the code uses conn->pghost which contains a comma-separated list of host names.
Added sentences to clarify connect_timeout when it is used with multiple hosts.
BTW, let me two questions.
Q1: Is there any reason why hostaddr doesn't accept multiple IP addresses?
Q2: pg_isready (and hence PQping() family) reports success when one host is alive and other hosts are down. Is this intended? I think this behavior is correct.
e.g. host1 is down and host2 is alive.
$ pg_isready -h host1,host2
host1,host2:5450 - accepting connections
$ echo $?
|Next Message||Peter Eisentraut||2016-11-14 02:51:34||Re: sequences and pg_upgrade|
|Previous Message||Alvaro Herrera||2016-11-14 01:35:51||Re: Physical append-only tables|
|Next Message||Tsunakawa, Takayuki||2016-11-14 06:01:23||Re: Patch: Implement failover on libpq connect level.|
|Previous Message||Peter Eisentraut||2016-11-11 14:03:55||Re: Patch: Implement failover on libpq connect level.|