Re: [RFC] Change the default of update_process_title to off

From: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [RFC] Change the default of update_process_title to off
Date: 2016-08-08 01:17:05
Message-ID: 0A3221C70F24FB45833433255569204D1F5BF836@G01JPEXMBYT05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: David Rowley [mailto:david(dot)rowley(at)2ndquadrant(dot)com]
> But perhaps it's better written like:
>
> + This value defaults to "off" on Windows platforms due to the
> platform's significant overhead for updating the process title.

Thank you, I copied this. But I changed "off" to off because other places in config.sgml don't enclose on/off with quotes.

> From: Robert Haas [mailto:robertmhaas(at)gmail(dot)com]
> On Fri, Aug 5, 2016 at 12:19 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> > Shouldn't we change the code which initdb uses to create the example
> > postgresql.conf, so that it shows the commented out value as being
> > 'off', when initdb is run on Windows?
>
> +1.

Good idea. Done.

Regards
Takayuki Tsunakawa

Attachment Content-Type Size
update_process_title_off_on_win_v2.patch application/octet-stream 1.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-08-08 01:44:57 Re: pg_ctl promote wait
Previous Message Michael Paquier 2016-08-08 00:51:57 Re: Refactoring of heapam code.