Re: [Patch] Checksums for SLRU files

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Ivan Kartyshov <i(dot)kartyshov(at)postgrespro(dot)ru>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: [Patch] Checksums for SLRU files
Date: 2018-05-17 05:30:35
Message-ID: 099C3F97-C79D-4E5C-A368-3D4B295B2681@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi, Ivan!

> 19 марта 2018 г., в 15:32, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> написал(а):
> I was looking into this patch mainly because I was reviewing other checksums patch in different thread. But the purpose of this patch seems viable for me.
> After looking into the patch I'd like to propose some editorialization:

I propose adding this patch to commitfest, if you do not object. We will have to add support for online SLRU checksum computation for this pages in spite of "Online enabling of checksums" patch(chances are that it will be committed earlier), so there is some work to do anyway. But I think it is good to keep this patch on the radars of potential reviewers.

Best regards, Andrey Borodin.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2018-05-17 05:33:26 Re: GiST VACUUM
Previous Message Amit Langote 2018-05-17 05:26:33 Re: postgres_fdw: Oddity in pushing down inherited UPDATE/DELETE joins to remote servers