| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade: Improve invalid option handling |
| Date: | 2019-06-18 08:25:44 |
| Message-ID: | 09070252-C74F-4831-B7BD-2949C45C856E@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 18 Jun 2019, at 10:15, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jun 14, 2019 at 12:34:36PM +0200, Daniel Gustafsson wrote:
>> + if ((log_opts.internal = fopen_priv(INTERNAL_LOG_FILE, "a")) == NULL)
>> + pg_fatal("could not write to log file \"%s\"\n", INTERNAL_LOG_FILE);
>>
>> While we’re at it, should we change this to “could not open log file” to make
>> the messaging more consistent across the utilities (pg_basebackup and psql both
>> use “could not open”)?
>
> I would suggest "could not open file \"%s\": %s" instead with a proper
> strerror().
Correct, that matches how pg_basebackup and psql does it.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2019-06-18 09:07:23 | Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions |
| Previous Message | Michael Paquier | 2019-06-18 08:15:24 | Re: pg_upgrade: Improve invalid option handling |