| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Elena Indrupskaya <e(dot)indrupskaya(at)postgrespro(dot)ru>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, n(dot)gluhov(at)postgrespro(dot)ru |
| Subject: | Re: SQL/JSON revisited |
| Date: | 2023-01-10 15:03:20 |
| Message-ID: | 073e573c-c3e5-86af-8cb3-4a0ab9e7f968@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-01-10 Tu 07:51, Elena Indrupskaya wrote:
> Hi,
>
> The Postgres Pro documentation team prepared another SQL/JSON
> documentation patch (attached), to apply on top of
> v1-0009-Documentation-for-SQL-JSON-features.patch.
> The new patch:
> - Fixes minor typos
> - Does some rewording agreed with Nikita Glukhov
> - Updates Docbook markup to make tags consistent across SQL/JSON
> documentation and across func.sgml, and in particular, consistent with
> the XMLTABLE function, which resembles SQL/JSON functions pretty much.
>
That's nice, but please don't post incremental patches like this. It
upsets the cfbot. (I wish there were a way to tell the cfbot to ignore
patches)
Also, I'm fairly certain that a good many of your changes are not
according to project style. The rule as I understand it is that
<parameter> is used for things that are parameters and <replaceable> is
only used for things that are not parameters. (I'm not sure where that's
documented other than the comment on commit 47046763c3, but it's what I
attempted to do with the earlier doc tidy up.)
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-01-10 15:17:13 | Re: Handle infinite recursion in logical replication setup |
| Previous Message | Tom Lane | 2023-01-10 14:46:35 | Re: split TOAST support out of postgres.h |