| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: cleaning perl code |
| Date: | 2020-04-09 18:26:45 |
| Message-ID: | 053dce96-107b-b73f-fe15-91aaf3c0c3a7@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-04-09 19:47, Robert Haas wrote:
> On Thu, Apr 9, 2020 at 11:44 AM Andrew Dunstan
> <andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>> We currently only run perlcritic at severity level 5, which is fairly
>> permissive. I'd like to reduce that, ideally to, say, level 3, which is
>> what I use for the buildfarm code.
>>
>> But let's start by going to severity level 4.
>
> I continue to be skeptical of perlcritic. I think it complains about a
> lot of things which don't matter very much. We should consider whether
> the effort it takes to keep it warning-clean has proportionate
> benefits.
Let's see what the patches look like. At least some of the warnings
look reasonable, especially in the sense that they are things casual
Perl programmers might accidentally do wrong.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2020-04-09 18:31:26 | Re: debian bugrept involving fast default crash in pg11.7 |
| Previous Message | Jeff Davis | 2020-04-09 18:25:56 | Re: Default setting for enable_hashagg_disk |