| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove an unnecessary errmsg_plural in dependency.c |
| Date: | 2022-03-24 13:11:01 |
| Message-ID: | 03088B0F-0A9B-43F6-9FC5-06BBB0AB7D27@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 24 Mar 2022, at 14:07, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 24.03.22 06:17, Kyotaro Horiguchi wrote:
>> The comment and errmsg_plural don't seem to be consistent. When the
>> code was added by c4f2a0458d, it had only singular form and already
>> had the comment. After that 8032d76b5 turned it to errmsg_plural
>> ignoring the comment. It seems like a thinko of 8032d76b5.
>
> I have removed the comment.
I was just typing a reply to your upthread answer that we should just remove
the comment then, so a retroactive +1 on this =)
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2022-03-24 13:19:31 | Re: multithreaded zstd backup compression for client and server |
| Previous Message | Peter Eisentraut | 2022-03-24 13:10:58 | Re: unlogged sequences |