Re: Amcheck verification of GiST and GIN

From: Tomas Vondra <tomas(at)vondra(dot)me>
To: Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Amcheck verification of GiST and GIN
Date: 2025-06-16 15:58:34
Message-ID: 016fd977-96ca-4a80-9ced-1c8c712aef8c@vondra.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks.

I went through the patches, polished the commit messages and did some
minor tweaks in patch 0002 (to make the variable names a bit more
consistent, and reduce the scope a little bit). I left it as a separate
patch to make the changes clearer, but it should be merged into 0002.

Please read through the commit messages, and let me know if I got some
of the details wrong (or not clear enough). Otherwise I plan to start
pushing this soon (~tomorrow).

regards

--
Tomas Vondra

Attachment Content-Type Size
v8-0001-amcheck-Add-gin_index_check-on-a-multicolumn-inde.patch text/x-patch 2.1 KB
v8-0002-amcheck-Fix-checks-of-entry-order-for-GIN-indexes.patch text/x-patch 12.4 KB
v8-0003-tweaks.patch text/x-patch 3.2 KB
v8-0004-amcheck-Fix-parent-key-check-in-gin_index_check.patch text/x-patch 5.8 KB
v8-0005-amcheck-Fix-posting-tree-checks-in-gin_index_chec.patch text/x-patch 4.4 KB
v8-0006-amcheck-Remove-unused-GinScanItem-parentlsn-field.patch text/x-patch 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-06-16 15:59:06 Re: Per-role disabling of LEAKPROOF requirements for row-level security?
Previous Message Konstantin Knizhnik 2025-06-16 15:48:27 Re: Non-reproducible AIO failure