Re: vacuum verbose detail logs are unclear; log at *start* of each stage

On 2020-01-26 06:36, Justin Pryzby wrote:
> From a3d0b41435655615ab13f808ec7c30e53e596e50 Mon Sep 17 00:00:00 2001
> From: Justin Pryzby<pryzbyj(at)telsasoft(dot)com>
> Date: Sat, 25 Jan 2020 21:25:37 -0600
> Subject: [PATCH v3 1/4] Remove gettext erronously readded at 580ddce
>
> ---
> src/backend/access/heap/vacuumlazy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c
> index 8ce5011..8e8ea9d 100644
> --- a/src/backend/access/heap/vacuumlazy.c
> +++ b/src/backend/access/heap/vacuumlazy.c
> @@ -1690,7 +1690,7 @@ lazy_scan_heap(Relation onerel, VacuumParams *params, LVRelStats *vacrelstats,
> "%u pages are entirely empty.\n",
> empty_pages),
> empty_pages);
> - appendStringInfo(&buf, _("%s."), pg_rusage_show(&ru0));
> + appendStringInfo(&buf, "%s.", pg_rusage_show(&ru0));
>
> ereport(elevel,
> (errmsg("\"%s\": found %.0f removable, %.0f nonremovable row versions in %u out of %u pages",
> -- 2.7.4

Why do you think it was erroneously added?

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services