Re: Plan B for log rotation support: borrow Apache code

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Plan B for log rotation support: borrow Apache code
Date: 2003-05-24 13:22:02
Message-ID: 002b01c321f7$77174bc0$6401a8c0@DUNSLANE
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Plan B.0.1 might be to get the version of rotatelogs.c from the Apache 1.3
branch so that removing the APR stuff wasn't necessary (IIRC APR is a purely
2.x thing in Apache).

Can be viewed here:
http://cvs.apache.org/viewcvs.cgi/apache-1.3/src/support/rotatelogs.c

Or else use the one from Peter, I don't care, just pointing out that
removing APR shouldn't be necessary.

andrew (big fan of not reinventing the wheel - good programmers write code,
great programmers steal code ;-)

----- Original Message -----
From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: <pgsql-hackers(at)postgresql(dot)org>
Sent: Friday, May 23, 2003 3:13 PM
Subject: [HACKERS] Plan B for log rotation support: borrow Apache code

> Something we've discussed repeatedly is adding a log rotation program to
> the distribution so that we don't have to hand-wave in the part of the
> documentation that talks about setting up non-syslog-based logging.
> A few weeks ago Andrew Sullivan offered the rotator his company uses,
> but there were various objections to it (mainly that it couldn't coexist
> with pg_ctl, IIRC).
>
> I think a reasonable Plan B is to borrow Apache's rotatelogs program
> hook, line, and sinker, and include it as a contrib module. It's small
> and it does exactly what we want: read stdin and drop it into a series
> of text files. The license can be read at
> http://www.apache.org/LICENSE.txt
> It's essentially BSD terms; I think all we would need to do differently
> from what we'd do with homegrown code is include the text of the Apache
> license in the README.rotatelogs documentation file that the contrib
> module would install.
>
> It would take an hour or two's work to put together a standalone version
> of rotatelogs.c (one that doesn't depend on the Apache Portable Runtime
> library). Seems well worth it to me. Does anyone have an objection to
> doing this?
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Martin Marques 2003-05-24 13:50:17 Re: Postgresql on SUN Server
Previous Message Peter Galbavy 2003-05-24 10:54:37 Re: 500 tpsQL + WAL log implementation