Re: Teach pg_receivewal to use lz4 compression

From: gkokolatos(at)pm(dot)me
To: gkokolatos(at)pm(dot)me
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Teach pg_receivewal to use lz4 compression
Date: 2021-11-03 09:11:24
Message-ID: zHbIxCUEoptJOiCQzyk-_PCLIPSrImAbI1Y98FW2dqeFQSIksCBwvGwYvpLwfQ32_t9cgsg64s-kPGvyC2DfY6UxVfPLW9s0EmPIrxg9mJE=@pm.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, November 3rd, 2021 at 9:05 AM, <gkokolatos(at)pm(dot)me> wrote:

> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Wednesday, November 3rd, 2021 at 12:23 AM, Michael Paquier michael(at)paquier(dot)xyz wrote:
> > On Tue, Nov 02, 2021 at 12:31:47PM -0400, Robert Haas wrote:
> > > On Tue, Nov 2, 2021 at 8:17 AM Magnus Hagander magnus(at)hagander(dot)net wrote:
> > >
> > > > I think for the end user, it is strictly better to name it "gzip",
> > > > and given that the target of this option is the end user we should
> > > > do so. (It'd be different it we were talking about a build-time
> > > > parameter to configure).
> > >
> > > I agree. Also, I think there's actually a file format called "zlib"
> > > which is slightly different from the "gzip" format, and you have to be
> > > careful not to generate the wrong one.
> >
> > Okay, fine by me. It would be better to be also consistent in
> > WalCompressionMethods once we switch to this option value, then.
>
> I will revert to gzip for version 9. Should be out shortly.

Please find v9 attached.

Cheers,
//Georgios
>
> > Michael

Attachment Content-Type Size
v9-0002-Teach-pg_receivewal-to-use-LZ4-compression.patch text/x-patch 19.2 KB
v9-0001-Refactor-pg_receivewal-in-preparation-for-introdu.patch text/x-patch 21.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2021-11-03 09:32:51 Re: lastOverflowedXid does not handle transaction ID wraparound
Previous Message Alexander Korotkov 2021-11-03 09:08:52 Re: lastOverflowedXid does not handle transaction ID wraparound