| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ci: namespace ccache by PostgreSQL major version |
| Date: | 2026-07-17 15:27:52 |
| Message-ID: | ybeudonc63cejz55fjlfzsqnylt6svipl6pgxaturlvqylq5xv@y7aokc35oak6 |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2026-07-17 11:57:18 +0300, Nazir Bilal Yavuz wrote:
> On Fri, 17 Jul 2026 at 00:27, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >
> > On 2026-07-07 13:35:34 -0400, Andres Freund wrote:
> > >
> > > Yea, I don't think that's the right answer. I'm reasonably sure I debugged
> > > this issue a while ago:
> > >
> > > https://postgr.es/m/phsrssp75npoyalqsolcd7fmnmlbzbmquc2p7w7mqjlw7432jk%40bzskz3luyjvb
> > >
> > > Not a lot has happened on the ccache front, so I suspect we should start
> > > adding the -fpch-deps flag I mentioned in that thread.
> > >
> > > We could make adding -fpch-deps conditional on pch support being enabled, but
> > > given that it doesn't do anything when pch is not used, I'd just add it when
> > > supported by the compiler.
> >
> > Attached is the change I propose.
>
> Thanks for the patch! LGTM and I confirm it fixes the problem.
Thanks for reviewing. Pushed.
Greetings,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul Kim | 2026-07-17 15:32:01 | [PATCH v2] amcheck: Allow interrupting the child-level rightlink walk |
| Previous Message | Jacob Champion | 2026-07-17 15:27:39 | Re: ci: namespace ccache by PostgreSQL major version |