Re: MSVC: Improve warning options set

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: MSVC: Improve warning options set
Date: 2025-11-03 19:15:59
Message-ID: y6k4ezo6t2zlz2z2i2ymu6zske5uehr76pfp67ckzq5cx3zb55@luywbxwevr4p
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-10-29 08:51:00 +0100, Peter Eisentraut wrote:
> meson.build has a list of warnings to disable on MSVC:
>
> cflags_warn += [
> '/wd4018', # signed/unsigned mismatch
> '/wd4244', # conversion from 'type1' to 'type2', possible loss of data
> '/wd4273', # inconsistent DLL linkage
> '/wd4101', # unreferenced local variable
> '/wd4102', # unreferenced label
> '/wd4090', # different 'modifier' qualifiers
> '/wd4267', # conversion from 'size_t' to 'type', possible loss of data
> ]
>
> First, these appear to be in some random order, so I wanted to sort them.

FWIW, I just transported them 1:1 from src/tools/msvc, at the time it seemed
more important to keep things consistent than to clean up.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-11-03 19:19:28 Re: [PG19-3 PATCH] Don't ignore passfile
Previous Message Daniel Verite 2025-11-03 19:14:03 Re: Remaining dependency on setlocale()