| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pg_stat_database.checksum_failures vs shared relations |
| Date: | 2025-03-28 17:47:16 |
| Message-ID: | xqxeo4ml5vchfveov26m4kfta4cif6rtedtupsx46jixokpkqe@cavgf5w747oz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Attached is a fix for the issue.
I looked around and didn't find extensions using PageIsVerified[Extended]() in
codesearch.debian.org, so I got rid of the compat macro and renamed
PageIsVerifiedExtended back to PageIsVerified().
Normally I'd commit tests as part of a fix like this, but since I've already
written test infrastructure for checksum failures and their stats as part of
aio, and those tests don't work without more of aio applied, I don't think it
makes sense to write them for just this test. It's not like anybody has ever
bothered to test checksum failures before...
Greetings,
Andres Freund
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-mis-attribution-of-checksum-failure-stats-to-the.patch | text/x-diff | 10.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2025-03-28 18:12:58 | Re: Test to dump and restore objects left behind by regression |
| Previous Message | Alvaro Herrera | 2025-03-28 17:16:29 | Re: Reducing memory consumed by RestrictInfo list translations in partitionwise join planning |