| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Ilyasov Ian <ianilyasov(at)outlook(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, "thomas(dot)munro(at)gmail(dot)com" <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: ReadRecentBuffer() doesn't scale well |
| Date: | 2026-01-22 16:55:55 |
| Message-ID: | wbmtz3b4cm3zwcsfunymbaauu7dlwbimzma7tsyjtg3npqy546@tj6oqcktgjvh |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2026-01-22 08:37:56 +0000, Ilyasov Ian wrote:
> Speaking of this patch, I've done a benchmark test on a master branch on 34740b90bc123d645a3a71231b765b778bdcf049 commit with a patch by Thomas Munro: https://www.postgresql.org/message-id/attachment/148040/0002-Use-ReadRecentBuffer-for-btree-root-page.patch and without it. The configuration of the server was 96 cores and 1.5 TB of RAM.
Which patch specifically do you mean?
An evolved version of 0001 from
https://postgr.es/m/CA%2BhUKGJ8N_DRSB0YioinWjS2ycMpmOLy32mbBqVVztwBvXgyJA%40mail.gmail.com
has already been applied (see 819dc118c0f).
So I guess you were testing 0002 from that email?
Or were you testing 0002 from
https://postgr.es/m/CA%2BhUKGLMFtNqei9nfcJy2SQMLWyYuO9E8NLYrb%3D4Gs1HgkAS7Q%40mail.gmail.com
which is a completely different patch?
> My conclusion is that this patch looks excellent on multicore systems and it would be great if it is committed.
> Also I have a question if committed whether this patch would be backported to 18th version?
We don't backpatch performance improvements unless they are addressing
performance issues that are so severe that they basically amount to a bug.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-01-22 16:58:14 | Re: Likely undefined behavior with some flexible arrays |
| Previous Message | Bertrand Drouvot | 2026-01-22 16:45:31 | Re: Flush some statistics within running transactions |