Re: [PATCH] psql: Add tab-complete for optional view parameters

From: Christoph Heiss <christoph(at)c8h4(dot)io>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Mikhail Gribkov <youzhick(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] psql: Add tab-complete for optional view parameters
Date: 2023-08-08 10:21:08
Message-ID: w77p7uemquoohjqn2bgrv7lkaowqn6whldal7jqqqshjflzh2w@z7pb5pvpvodb
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Aug 08, 2023 at 09:17:51AM +0100, Dean Rasheed wrote:
> On Mon, 7 Aug 2023 at 19:49, Christoph Heiss <christoph(at)c8h4(dot)io> wrote:
> >
> > On Fri, Jan 06, 2023 at 12:18:44PM +0000, Dean Rasheed wrote:
> > > Hmm, I don't think we should be offering "check_option" as a tab
> > > completion for CREATE VIEW at all, since that would encourage users to
> > > use non-SQL-standard syntax, rather than CREATE VIEW ... WITH
> >
> > Left that part in for now. I would argue that it is a well-documented
> > combination and as such users would expect it to turn up in the
> > tab-complete as well. OTOH not against removing it either, if there are
> > others voicing the same opinion ..
> >
> On reflection, I think that's probably OK. I mean, I still don't like
> the fact that it's offering to complete with non-SQL-standard syntax,
> but that seems less bad than using an incomplete list of options, and
> I don't really have any other better ideas.

My thought pretty much as well. While obviously far from ideal as you
say, it's the less bad case of these both. I would also guess that it is
not the only instance of non-SQL-standard syntax completion in psql ..

Thanks for weighing in once again.


In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2023-08-08 10:38:30 Re: Reducing memory consumed by RestrictInfo list translations in partitionwise join planning
Previous Message Peter Eisentraut 2023-08-08 10:20:24 Re: Fix last unitialized memory warning