Re: Upload only the failed tests logs to the Postgres CI (Cirrus CI)

Hi,

On 2026-06-05 15:23:52 +0300, Nazir Bilal Yavuz wrote:
> I implemented it as another step which will run if the job fails.
> Alternatively, we can put 'the clearing command' into the
> meson_test_world step, this makes the change simpler but then this
> command will run although tests don't fail.

I think it's the right thing to have it as a dedicated step. That way it can
work with things like the running tests etc as well.

>
> + # Clear test folder so only failed tests are left

FWIW, I'd much rather see this copy the to-be-archived logs to a different
location, instead of removing the unneeded logs.

> + - &clear_test_folder_step
> + name: Clear test folder
> + if: failure() && !cancelled()
> + run: |
> + meson compile clear_testrun_folder -C build

I don't think I see what we gain from invoking this via meson compile, given
that we invoke ninja directly elsewhere. Not that that's going to make the
difference, but meson compile, which internally invokes ninja, is noticeably
slower than going through ninja directly.

But I suspect this shouldn't be integrated into the build system directly, as
I think we should eventually make this work for autoconf as well.

Greetings,

Andres Freund