| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Defend against -ffast-math in meson builds |
| Date: | 2026-03-11 13:43:51 |
| Message-ID: | vwnxbsap65km373ghtqhhvhwnc35suwraegb7z5op4okxyuwzu@kpaumampogpe |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2026-03-11 11:52:28 +0000, Bertrand Drouvot wrote:
> while working on a patch (not shared yet), I had issues with floating-point and
> realized that we don't defend against -ffast-math in meson builds. We defend
> against in autoconf (because we don't want fast-math optimizations [1]), so the
> attached does the same for meson.
I don't find this (nor the autoconf check) particularly likely to be
helpful. The most likely way the flag would unintentionally be added would be
via the cflags of some dependency - which won't be picked up by the tests.
However we do have tests during the builds that should pick it up, in date.c
and timestamp.c...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ayush Tiwari | 2026-03-11 13:50:01 | Re: tid_blockno() and tid_offset() accessor functions |
| Previous Message | Andres Freund | 2026-03-11 13:37:19 | Re: Remove header lock BufferGetLSNAtomic() on architectures with 64 bit atomic operations |