Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?

Hi,

On 2026-04-23 23:16:07 -0700, Lukas Fittl wrote:
> Thanks for confirming!
>
> I've checked with Andres off-list whether he wants to fix this
> separately, or together with the earlier proposed patch to show TSC
> debug info in pg_test_timing. Andres proposed we take care of this in
> the same commit.
>
> Attached v29 patch that contains those earlier changes, plus this
> Coverity fix. I've also adjusted x86_tsc_frequency_khz slightly to
> clarify the new arguments, and wordsmithed the commit message a bit
> for clarity plus explain why we're making this change now.
>
> FWIW, I don't think the TSC debug info change violates any feature
> freeze guidelines, and it would have helped investigate the issue on
> drongo / have it fail independently of the tablesample tests being
> affected by the issue. I think any TSC frequency related bug reports
> during beta period will also be greatly aided by having this.

Agreed.

Sorry for loosing track of this for the last couple weeks, I've been
travelling somewhat crazily. Pushed now. Let's see whether the BF finds
other problems.

Greetings,

Andres