From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: meson: Add _static and _shared suffixes to the library names |
Date: | 2025-08-13 20:03:14 |
Message-ID: | vamgzetvo3ufycsy2xlqqtowt67y5g6oseaaisltn6tb6eq5c3@bpoc52i5tvhf |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2025-08-13 10:24:07 -0400, Andres Freund wrote:
> > 2- Using '/DEBUG:FULL' instead of '/DEBUG:FASTLINK' in the Windows CI
> > task but this causes more memory to be used. It seems that the error
> > appears only when the '/DEBUG:FASTLINK' is set. '/DEBUG:FULL' is a
> > default option, so we may decide to not add it at all. I explicitly
> > added it as I found this easier to understand. This approach fixes the
> > build but I think it is not the correct fix, we will have one .pdb
> > file after this fix; not one for each library type.
>
> I think it's an acceptable fix for now. I added /DEBUG:FASTLINK to the CI
> task when it was using windows containers, as we'd run out of memory
> occasionally. But since we aren't using those anymore, I think the best way to
> make CI work again is to simply stop using /DEBUG:FASTLINK.
I'll push it this way once the test completes that way in my repo. I want to
get cfbot green again. If we want to do it differently than in Bilal's
v2-0002-ci-windows-Use-DEBUG-FULL-instead-of-DEBUG-FASTLI.patch
I however removed DEBUG:FULL, I don't see a point of explicitly specifying the
default value.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2025-08-13 20:04:04 | Re: ReplicationSlotRelease() crashes when the instance is in the single user mode |
Previous Message | Andres Freund | 2025-08-13 19:38:14 | Re: AIO writes vs hint bits vs checksums |