| From: | Dongpo Liu <poe(dot)liu(at)pm(dot)me> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_*_advice: tsv load failure, etc. |
| Date: | 2026-10-26 20:13:30 |
| Message-ID: | vMqIs9r_o3Uku4EOvqGeKgns8SwKk0kR-5kYhIvsYkn4Ns-tioM07p2yHK3oCZlkOGjHf_jimtpjjlqVFy9qTb7wo_IvO9wjZ56QjVnk6Js=@pm.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I reviewed the patch, and it looks good to me. The change is small
and effective. I ran the tests locally: the new TAP test fails
without the fix and passes with it.
The possible extra write after a worker restart is one more write of
a small file, so I don't think it is a problem. I also tried to keep
the last saved change count in shared memory to prevent that write.
It works, but it adds shared state only to save one write, so I
agree with the approach in your patch.
Regards,
Dongpo Liu
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Daniel Gustafsson | 2026-10-26 19:54:16 | Re: PL/pgSQL: FOUND is NULL, not false, in event trigger functions |