Re: Don't synchronously wait for already-in-progress IO in read stream

From: Andres Freund <andres(at)anarazel(dot)de>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>, Tomas Vondra <tv(at)fuzzy(dot)cz>
Subject: Re: Don't synchronously wait for already-in-progress IO in read stream
Date: 2026-03-25 21:58:46
Message-ID: tjhnl6hiooo4aj6tktyehf4pn4yxcaqndlqebgpmynw4tmticq@odfcssnjf2qu
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Attached is an updated set of patches. I fixed the bug that Melanie noticed,
updated the comments a bit further and added a new commit that adds a decent
bit of coverage of StartReadBuffers(), including all the cases in
StartSharedBufferIO and most of the cases in StartLocalBufferIO().

I'm planning to commit 0001 soon - it hasn't changed in a while. Then I'd like
to get 0002 committed soon after, but I'll hold off for that until tomorrow,
given that nobody has looked at it (as it's new). I think 0004-0007 can be
committed too, but I am not sure if you (Melanie) want to do so.

I'd like to get the rest committed tomorrow too.

Greetings,

Andres Freund

Attachment Content-Type Size
v8-0001-aio-Refactor-tests-in-preparation-for-more-tests.patch text/x-diff 10.9 KB
v8-0002-test_aio-Add-basic-tests-for-StartReadBuffers.patch text/x-diff 15.8 KB
v8-0003-test_aio-Add-read_stream-test-infrastructure-test.patch text/x-diff 22.9 KB
v8-0004-Fix-off-by-one-error-in-read-IO-tracing.patch text/x-diff 2.4 KB
v8-0005-Pass-io_object-and-io_context-through-to-PinBuffe.patch text/x-diff 3.5 KB
v8-0006-Make-buffer-hit-helper.patch text/x-diff 5.0 KB
v8-0007-Restructure-AsyncReadBuffers.patch text/x-diff 7.8 KB
v8-0008-bufmgr-Improve-StartBufferIO-interface.patch text/x-diff 28.8 KB
v8-0009-aio-Don-t-wait-for-already-in-progress-IO.patch text/x-diff 7.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2026-03-25 22:00:24 Re: another autovacuum scheduling thread
Previous Message Zsolt Parragi 2026-03-25 21:56:00 Re: meson vs. llvm bitcode files