Re: Fix outdated comments in catcache.h

From: cca5507 <cca5507(at)qq(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix outdated comments in catcache.h
Date: 2026-01-05 09:43:27
Message-ID: tencent_EDDA39847A1476D42EA528C834E2751E340A@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> > - dlist_node cache_elem; /* list member of per-catcache list */
> > + dlist_node cache_elem; /* list member of per-bucket list */
>
> I'm not sure this is more informative. How about?
>
> dlist_node cache_elem; /* member for CatCache.cc_lbucket[] dlist */
>
> I also really wonder what the fascination with having lower-case
> struct names with camelCased typedef names in this file... It's not
> really clear if that comment should say "CatCache.cc_lbucket[]" or
> "catcache.cc_lbucket[]". I find the latter clearer so used that.

Your suggestion looks better, and we also need to update the comment
of CatCTup.cache_elem.

--
Regards,
ChangAo Chen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2026-01-05 09:43:41 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Anders Åstrand 2026-01-05 09:41:58 Re: [Proposal] Generate pkg-config for server module development