Copy-paste error in hash_record_extended() — args[1].isnull not set

From: zengman <zengman(at)halodbtech(dot)com>
To: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Copy-paste error in hash_record_extended() — args[1].isnull not set
Date: 2026-05-30 04:38:02
Message-ID: tencent_7818173C01E01836109848C3@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

I noticed that in src/backend/utils/adt/rowtypes.c, function hash_record_extended(), there is a copy-paste error:

```c
diff --git a/src/backend/utils/adt/rowtypes.c b/src/backend/utils/adt/rowtypes.c
index e4eb7111ee7..d6126d431d9 100644
--- a/src/backend/utils/adt/rowtypes.c
+++ b/src/backend/utils/adt/rowtypes.c
@@ -2030,7 +2030,7 @@ hash_record_extended(PG_FUNCTION_ARGS)
locfcinfo->args[0].value = values[i];
locfcinfo->args[0].isnull = false;
locfcinfo->args[1].value = Int64GetDatum(seed);
- locfcinfo->args[0].isnull = false;
+ locfcinfo->args[1].isnull = false;
element_hash = DatumGetUInt64(FunctionCallInvoke(locfcinfo));

/* We don't expect hash support functions to return null */
```
I think it's worth fixing.

Regards,
Man Zeng

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-05-30 04:47:52 Re: Copy-paste error in hash_record_extended() — args[1].isnull not set
Previous Message Nisha Moond 2026-05-30 04:32:41 Re: Support EXCEPT for TABLES IN SCHEMA publications