| From: | cca5507 <cca5507(at)qq(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Fix incorrect comments in tuplesort.c |
| Date: | 2025-12-06 14:56:40 |
| Message-ID: | tencent_6FA14F85D6B5B5291532D6789E07F4765C08@qq.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
The incorrect comment:
```
/*
* Initial size of memtuples array. We're trying to select this size so that
* array doesn't exceed ALLOCSET_SEPARATE_THRESHOLD and so that the overhead of
* allocation might possibly be lowered. However, we don't consider array sizes
* less than 1024.
*
*/
#define INITIAL_MEMTUPSIZE Max(1024, \
ALLOCSET_SEPARATE_THRESHOLD / sizeof(SortTuple) + 1)
```
The "doesn't exceed" are contrary to the macro. Maybe "slightly exceed"?
Attach a small patch. (also remove the empty line in this comment)
--
Regards,
ChangAo Chen
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-incorrect-comments-in-tuplesort.c.patch | application/octet-stream | 993 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2025-12-06 15:06:30 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Marcos Pegoraro | 2025-12-06 12:18:41 | Initial COPY of Logical Replication is too slow |