Re: (SQL/PGQ) Clean up orphaned properties when dropping a label

From: zengman <zengman(at)halodbtech(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: (SQL/PGQ) Clean up orphaned properties when dropping a label
Date: 2026-06-12 01:36:28
Message-ID: tencent_645E2A4E416C0065571467F5@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Thanks for the report and the patch. The fix is on the right track. I
> changed a few things as follows
> a. we usually add operands to the same operator at the end, not at the
> beginning.
> b. create_property_graph.sql, which tests all property graph DDLs, is
> the right place to add these tests. graph_table.sql tests graph query.
>
> I have used an existing property graph in create_property_graph.sql in
> the test. It removes a label from the property graph which has two
> properties associated with it, one that gets orphaned and one that
> doesn't. We can verify that the orphaned property gets dropped from
> the property graph but not the other one by information schema query
> outputs later. So didn't add any separate verification step after the
> DDL.

> Attached patch with those changes.

Hi Ashutosh,

Thank you for your assistance. This looks better. There is a small problem that

https://commitfest.postgresql.org/patch/6848/

It seems that a 'rebase' is needed to conduct the test normally. Could you please make some adjustments again?

--
regards,
Man Zeng

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Henson Choi 2026-06-12 01:48:32 Re: LLVM JIT: any JIT-compiled query crashes (SIGILL) on a libLLVM 19 + ASAN build
Previous Message Kyotaro Horiguchi 2026-06-12 01:10:30 Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements