Re:Add pg_get_publication_ddl function

From: zengman <zengman(at)halodbtech(dot)com>
To: Jonathan Gonzalez V(dot) <jonathan(dot)abdiel(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re:Add pg_get_publication_ddl function
Date: 2026-01-11 12:18:13
Message-ID: tencent_4D7CAAFE3DC969CD0F75BD90@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I haven't tested your patch yet, but I noticed a few points that may need adjustment:

Based on your code logic, the pub parameter passed here can never be NULL — if the corresponding PUBLICATION does not exist, an error should have already been thrown earlier in the code flow.
Therefore, the following code block can be removed, and the usage of return (Datum) NULL; in this block is also incorrect:
```
if (pub == NULL)
return (Datum) NULL;
```
pubtuple is not being freed — please use heap_freetuple to release it.

The format string "%sALL SEQUENCE" should be corrected to "%sALL SEQUENCES".

--
Regards,
Man Zeng
www.openhalo.org

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2026-01-11 12:56:57 Re: Add WALRCV_CONNECTING state to walreceiver
Previous Message jian he 2026-01-11 12:11:00 Re: JumbleQuery ma treat different GROUP BY expr as the same