| From: | zengman <zengman(at)halodbtech(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Erik Wienhold <ewie(at)ewie(dot)name> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Regression with large XML data input |
| Date: | 2025-12-26 06:28:53 |
| Message-ID: | tencent_46A7A7C74F1494DD5A72CF5C@qq.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> usefulness [1]. I don't love doing that for xml.c, because it
> would put a permanent block on our seeing future deprecation
> issues (until they become outright build failures). Still...
Under the current condition that the relevant code here is not modified, this might be an acceptable temporary solution.
> > But do we need the same guard for GCC here as well?
>
> Yeah, we would. Non-gcc-alike compilers are unlikely to accept that
> switch. We would also need a fix for the meson build system.
Patch 0002 adds GCC checking. Additionally, I tested the meson build system and saw no warnings with the `-Dc_args="-Wall"` configuration.
```
meson setup .. --prefix=$PGHOME -Dc_args="-Wall"
postgres(at)zxm-VMware-Virtual-Platform:~/code/postgres/build$ meson compile -j8
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -j 8
[2471/2471] Linking target src/interfaces/ecpg/test/thread/alloc
postgres(at)zxm-VMware-Virtual-Platform:~/code/postgres/build$
```
--
Regards,
Man Zeng
www.openhalo.org
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Suppress-deprecation-warning-for-xmlKeepBlanksDefaul.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-12-26 06:41:01 | Re: Sequence Access Methods, round two |
| Previous Message | Michael Paquier | 2025-12-26 05:59:33 | Re: Fixes a clip bug in pg_stat_get_backend_activity() |