Re: Speed up ICU case conversion by using ucasemap_utf8To*()

From: zengman <zengman(at)halodbtech(dot)com>
To: Andreas Karlsson <andreas(at)proxel(dot)se>, Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Speed up ICU case conversion by using ucasemap_utf8To*()
Date: 2026-01-03 03:05:24
Message-ID: tencent_3C4ABC775EDA640F219A5E69@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Here is a version 4 of the patch which uses the fact that we have method
> tables to remove one level of indirection. I am not sure the extra lines
> of codes are worth it but on the other hand despite 40 more lines the
> code became easier to read to me. What do you think?

I don't have any major objections, but I noticed a few minor details that might need a bit more tweaking.

`signficant` -> `significant`
`realtively` -> `relatively`
`if (status != U_BUFFER_OVERFLOW_ERROR && U_FAILURE(status))` -> `if (U_FAILURE(status) && status != U_BUFFER_OVERFLOW_ERROR)`

--
Regards,
Man Zeng
www.openhalo.org

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2026-01-03 03:09:47 Re: LLVM JITLink attempt II (WIP)
Previous Message Tom Lane 2026-01-03 02:40:23 Re: Bug in amcheck?