| From: | zengman <zengman(at)halodbtech(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] Fix error message in RemoveWalSummaryIfOlderThan to indicate file removal failure |
| Date: | 2026-02-01 14:43:27 |
| Message-ID: | tencent_3BBE865C5F49D452360FF190@qq.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
I noticed a small issue. In `RemoveWalSummaryIfOlderThan`,an `unlink()` failure incorrectly logs "could not stat file", likely a copy-paste error.
I updated it to "could not remove file". No functional changes.
```
diff --git a/src/backend/backup/walsummary.c b/src/backend/backup/walsummary.c
index 21164faac7e..4ee510092f9 100644
--- a/src/backend/backup/walsummary.c
+++ b/src/backend/backup/walsummary.c
@@ -251,7 +251,7 @@ RemoveWalSummaryIfOlderThan(WalSummaryFile *ws, time_t cutoff_time)
if (unlink(path) != 0)
ereport(ERROR,
(errcode_for_file_access(),
- errmsg("could not stat file \"%s\": %m", path)));
+ errmsg("could not remove file \"%s\": %m", path)));
ereport(DEBUG2,
(errmsg_internal("removing file \"%s\"", path)));
}
```
--
regards,
Man Zeng
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-error-message-in-RemoveWalSummaryIfOlderThan-to-.patch | application/octet-stream | 899 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2026-02-01 14:49:31 | Re: Batching in executor |
| Previous Message | Alexander Lakhin | 2026-02-01 14:00:00 | Re: Improving tracking/processing of buildfarm test failures |