Re:17f446784d54da827f74c2acc0fa772a41b92354 breaks orafce build

From: zengman <zengman(at)halodbtech(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re:17f446784d54da827f74c2acc0fa772a41b92354 breaks orafce build
Date: 2025-12-26 09:42:20
Message-ID: tencent_30132FCF7F17CB2A6DA9BBC8@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

If you are in a hurry, you can try modifying the code of 'orafce' in this way.
```
postgres(at)zxm-VMware-Virtual-Platform:~/code/18/contrib/orafce$ git diff
diff --git a/Makefile b/Makefile
index ac72aa5..5772627 100644
--- a/Makefile
+++ b/Makefile
@@ -95,7 +95,7 @@ REGRESS = orafce\

#REGRESS_OPTS = --load-language=plpgsql --schedule=parallel_schedule --encoding=utf8
REGRESS_OPTS = --schedule=parallel_schedule --encoding=utf8
-
+override CFLAGS += -D'static_assert=_Static_assert'
# override CFLAGS += -Wextra -Wimplicit-fallthrough=0

ifdef NO_PGXS
diff --git a/datefce.c b/datefce.c
index 3cc42cd..fc1e5d6 100644
--- a/datefce.c
+++ b/datefce.c
@@ -1281,7 +1281,11 @@ orafce_sys_extract_utc_oracle_date(PG_FUNCTION_ARGS)
{
TimestampTz loc_ts;

-#if PG_VERSION_NUM >= 130000
+#if PG_VERSION_NUM >= 180000
+
+ loc_ts = timestamp2timestamptz_safe(PG_GETARG_TIMESTAMP(0), NULL);
+
+#elif PG_VERSION_NUM >= 130000

loc_ts = timestamp2timestamptz_opt_overflow(PG_GETARG_TIMESTAMP(0), NULL);
```

--
Regards,
Man Zeng
www.openhalo.org

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2025-12-26 09:57:22 Re: Skipping schema changes in publication
Previous Message Japin Li 2025-12-26 09:27:25 Re: remove unnecessary include in src/backend/commands/policy.c